skyler
/
Lightningbeam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix remaining sites that weren't updating properly on BPM changes

This commit is contained in:
Skyler Lehmkuhl 2026-04-01 09:33:35 -04:00
parent cfb8e4462b
commit 3fc4773ec3
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
daw-backend/src/audio/engine.rs
View File

@ -3157,8 +3157,11 @@ impl Engine {
// Add new events from the recorded notes // Add new events from the recorded notes
// Timestamps are now stored in seconds (sample-rate independent) // Timestamps are now stored in seconds (sample-rate independent)
let bpm = self.current_bpm;
let fps = self.current_fps;
for (start_time, note, velocity, duration) in notes.iter() { for (start_time, note, velocity, duration) in notes.iter() {
let note_on = MidiEvent::note_on(*start_time, 0, *note, *velocity); let mut note_on = MidiEvent::note_on(*start_time, 0, *note, *velocity);
note_on.sync_from_seconds(bpm, fps);
eprintln!("[MIDI_RECORDING] Note {}: start_time={:.3}s, duration={:.3}s", eprintln!("[MIDI_RECORDING] Note {}: start_time={:.3}s, duration={:.3}s",
note, start_time, duration); note, start_time, duration);
@ -3167,7 +3170,8 @@ impl Engine {
// Add note off event // Add note off event
let note_off_time = *start_time + *duration; let note_off_time = *start_time + *duration;
let note_off = MidiEvent::note_off(note_off_time, 0, *note, 64); let mut note_off = MidiEvent::note_off(note_off_time, 0, *note, 64);
note_off.sync_from_seconds(bpm, fps);
clip.events.push(note_off); clip.events.push(note_off);
} }
@ -3180,6 +3184,7 @@ impl Engine {
if let Some(instance) = track.clip_instances.iter_mut().find(|i| i.clip_id == clip_id) { if let Some(instance) = track.clip_instances.iter_mut().find(|i| i.clip_id == clip_id) {
instance.internal_end = recording_duration; instance.internal_end = recording_duration;
instance.external_duration = recording_duration; instance.external_duration = recording_duration;
instance.sync_from_seconds(bpm, fps);
eprintln!("[MIDI_RECORDING] Updated clip instance timing: internal_end={:.3}s, external_duration={:.3}s", eprintln!("[MIDI_RECORDING] Updated clip instance timing: internal_end={:.3}s, external_duration={:.3}s",
instance.internal_end, instance.external_duration); instance.internal_end, instance.external_duration);
} }

5
lightningbeam-ui/lightningbeam-editor/src/panes/timeline.rs
View File

@ -5198,8 +5198,9 @@ impl PaneRenderer for TimelinePane {
&& self.time_display_format == lightningbeam_core::document::TimelineMode::Measures && self.time_display_format == lightningbeam_core::document::TimelineMode::Measures
{ {
use lightningbeam_core::actions::ChangeBpmAction; use lightningbeam_core::actions::ChangeBpmAction;
// Revert the live-preview mutation so the action owns it // document.bpm is already new_bpm from the live preview — keep it.
shared.action_executor.document_mut().bpm = start_bpm; // ChangeBpmAction::new uses the passed old/new params, not document.bpm,
// so we don't need to revert (which would cause a one-frame flash).
let action = ChangeBpmAction::new( let action = ChangeBpmAction::new(
start_bpm, start_bpm,
new_bpm, new_bpm,