From 822359364934946496e14b3324d7729ad8d03ae6 Mon Sep 17 00:00:00 2001 From: Skyler Lehmkuhl Date: Sun, 21 Jun 2026 16:49:08 -0400 Subject: [PATCH] CI: activate MSVC dev environment for the Windows build The cmake crate building nam-ffi/NeuralAudio panicked with "couldn't determine visual studio generator" because the Windows job never ran vcvars, so cmake-rs had no VisualStudioVersion to detect the VS generator from. Add an ilammy/msvc-dev-cmd step (x64) after the Windows dependency install; it runs vcvars and exports the env to later steps so the C++ build can configure. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/build.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7257b45..d3651b5 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -90,6 +90,15 @@ jobs: shell: pwsh run: choco install cmake llvm --installargs 'ADD_CMAKE_TO_PATH=System' -y + # Activate the MSVC developer environment (runs vcvars) so the cmake crate + # building nam-ffi/NeuralAudio can determine the Visual Studio generator. + # Without this, cmake-rs panics with "couldn't determine visual studio generator". + - name: Set up MSVC developer environment (Windows) + if: matrix.platform == 'windows-latest' + uses: ilammy/msvc-dev-cmd@v1 + with: + arch: x64 + # ── Common build steps ── - name: Extract version id: version