From a98b59a6d3ec8bc626d51973d35ebd801ac72a47 Mon Sep 17 00:00:00 2001
From: Skyler Lehmkuhl <skycooler@gmail.com>
Date: Thu, 19 Feb 2026 10:21:48 -0500
Subject: [PATCH] Clean up build warnings

---
 daw-backend/src/lib.rs                        |  4 +--
 .../lightningbeam-editor/src/debug_overlay.rs |  2 +-
 .../src/panes/shader_editor.rs                | 25 +++++++++----------
 3 files changed, 15 insertions(+), 16 deletions(-)

diff --git a/daw-backend/src/lib.rs b/daw-backend/src/lib.rs
index d780537..996a401 100644
--- a/daw-backend/src/lib.rs
+++ b/daw-backend/src/lib.rs
@@ -71,10 +71,10 @@ impl AudioSystem {
         let default_output_config = output_device.default_output_config().map_err(|e| e.to_string())?;
         let sample_rate = default_output_config.sample_rate();
         let channels = default_output_config.channels() as u32;
-        let debug_audio = std::env::var("DAW_AUDIO_DEBUG").map_or(false, |v| v == "1");
+        let _debug_audio = std::env::var("DAW_AUDIO_DEBUG").map_or(false, |v| v == "1");
 
         eprintln!("[AUDIO] Device: {:?}, format={:?}, rate={}, channels={}",
-            output_device.name().unwrap_or_default(), default_output_config.sample_format(), sample_rate, channels);
+            output_device.description().map(|d| d.name().to_string()).unwrap_or_default(), default_output_config.sample_format(), sample_rate, channels);
 
         // Create queues
         let (command_tx, command_rx) = rtrb::RingBuffer::new(512); // Larger buffer for MIDI + UI commands
diff --git a/lightningbeam-ui/lightningbeam-editor/src/debug_overlay.rs b/lightningbeam-ui/lightningbeam-editor/src/debug_overlay.rs
index c840682..518dd49 100644
--- a/lightningbeam-ui/lightningbeam-editor/src/debug_overlay.rs
+++ b/lightningbeam-ui/lightningbeam-editor/src/debug_overlay.rs
@@ -203,7 +203,7 @@ fn enumerate_audio_input_devices() -> Vec<String> {
         .ok()
         .map(|devices| {
             devices
-                .filter_map(|d| d.name().ok())
+                .filter_map(|d| d.description().ok().map(|desc| desc.name().to_string()))
                 .collect()
         })
         .unwrap_or_default()
diff --git a/lightningbeam-ui/lightningbeam-editor/src/panes/shader_editor.rs b/lightningbeam-ui/lightningbeam-editor/src/panes/shader_editor.rs
index aa21332..95c34c1 100644
--- a/lightningbeam-ui/lightningbeam-editor/src/panes/shader_editor.rs
+++ b/lightningbeam-ui/lightningbeam-editor/src/panes/shader_editor.rs
@@ -586,20 +586,19 @@ impl ShaderEditorPane {
             // Open dropdown for existing scripts (BeamDSP mode)
             if self.mode == EditorMode::BeamDSP && !available_scripts.is_empty() {
                 let open_btn = ui.button("Open");
-                let popup_id = egui::Id::new("script_editor_open_popup");
-                if open_btn.clicked() {
-                    ui.memory_mut(|m| m.toggle_popup(popup_id));
-                }
-                egui::popup_below_widget(ui, popup_id, &open_btn, egui::PopupCloseBehavior::CloseOnClickOutside, |ui| {
-                    ui.set_min_width(160.0);
-                    for (id, name) in available_scripts {
-                        let is_current = self.editing_script_id == Some(*id);
-                        if ui.selectable_label(is_current, name).clicked() {
-                            open_script_id = Some(*id);
-                            ui.memory_mut(|m| m.close_popup(popup_id));
+                let popup_id = egui::Popup::default_response_id(&open_btn);
+                egui::Popup::from_toggle_button_response(&open_btn)
+                    .close_behavior(egui::PopupCloseBehavior::CloseOnClickOutside)
+                    .show(|ui| {
+                        ui.set_min_width(160.0);
+                        for (id, name) in available_scripts {
+                            let is_current = self.editing_script_id == Some(*id);
+                            if ui.selectable_label(is_current, name).clicked() {
+                                open_script_id = Some(*id);
+                                egui::Popup::close_id(ui.ctx(), popup_id);
+                            }
                         }
-                    }
-                });
+                    });
             }
 
             ui.separator();