skyler
/
Lightningbeam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stop virtual piano from stealing keyboard focus from input elements

This commit is contained in:
Skyler Lehmkuhl 2026-02-16 06:16:05 -05:00
parent 65fa8a3918
commit da147fe6d4
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lightningbeam-ui/lightningbeam-editor/src/panes/virtual_piano.rs
View File

@ -758,13 +758,24 @@ impl PaneRenderer for VirtualPianoPane {
return; return;
} }
// Request keyboard focus to prevent tool shortcuts from firing // Request keyboard focus to prevent tool shortcuts from firing,
// This sets wants_keyboard_input() to true // but yield to text input widgets (node finder search, group rename, etc.)
let piano_id = ui.id().with("virtual_piano_keyboard"); let piano_id = ui.id().with("virtual_piano_keyboard");
ui.memory_mut(|m| m.request_focus(piano_id)); let other_has_focus = ui.memory(|m| {
m.focused().map_or(false, |id| id != piano_id)
});
if !other_has_focus {
ui.memory_mut(|m| m.request_focus(piano_id));
}
// Handle keyboard input FIRST // Handle keyboard input (skip when a text field has focus)
self.handle_keyboard_input(ui, shared); if other_has_focus {
if !self.active_key_presses.is_empty() {
self.release_all_keyboard_notes(shared);
}
} else {
self.handle_keyboard_input(ui, shared);
}
// Calculate visible range (needed for both rendering and labels) // Calculate visible range (needed for both rendering and labels)
let (visible_start, visible_end, white_key_width, offset_x) = let (visible_start, visible_end, white_key_width, offset_x) =