skyler
/
egui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change Spinner widget to account for width as well as height (#7560) 

Previously, when `rect` was taller than it was wide, the spinner would
render far outside the given rectangle. Now, it always renders inside
the smaller of the two dimensions.

I noticed this when upgrading from 0.30 to 0.32. I have an image that's
significantly taller than it is wide. In 0.32, when the image is
loading, it shows the spinner. Since the spinner radius is determined
solely based on rectangle height, the spinner ends up far too wide and
covers other elements.

* [x] I have followed the instructions in the PR template
This commit is contained in:
Bryce Berger 2025-10-09 06:47:59 -04:00 committed by GitHub
parent da39198142
commit 0abeccebc9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/egui/src/widgets/spinner.rs
View File

@ -42,7 +42,7 @@ impl Spinner {
let color = self let color = self
.color .color
.unwrap_or_else(|| ui.visuals().strong_text_color()); .unwrap_or_else(|| ui.visuals().strong_text_color());
let radius = (rect.height() / 2.0) - 2.0; let radius = (rect.height().min(rect.width()) / 2.0) - 2.0;
let n_points = (radius.round() as u32).clamp(8, 128); let n_points = (radius.round() as u32).clamp(8, 128);
let time = ui.input(|i| i.time); let time = ui.input(|i| i.time);
let start_angle = time * std::f64::consts::TAU; let start_angle = time * std::f64::consts::TAU;