skyler
/
egui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix bug causing wrong-fire of `ViewportCommand::Visible` (#5244) 

Fix: variable name issue

I'm not sure, if there's any particular reason to do `self.active` .
I thought `self.visible` was the original intention.
This commit is contained in:
rustbasic 2024-10-10 22:51:52 +09:00 committed by GitHub
parent 7bd6f83f18
commit 23728e145e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/egui/src/viewport.rs
View File

@ -728,7 +728,7 @@ impl ViewportBuilder {
} }
if let Some(new_visible) = new_visible { if let Some(new_visible) = new_visible {
if Some(new_visible) != self.active { if Some(new_visible) != self.visible {
self.visible = Some(new_visible); self.visible = Some(new_visible);
commands.push(ViewportCommand::Visible(new_visible)); commands.push(ViewportCommand::Visible(new_visible));
} }