skyler
/
egui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Write .new.png file if snapshot is missing (#7610) 

We should write the .new.png whenever the test fails and snapshots
aren't updated. Necessary for the kitdiff-snapshot-update-workflow to
work
This commit is contained in:
Lucas Meurer 2025-10-09 09:15:18 +02:00 committed by GitHub
parent 9e13889589
commit 32336e260b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
crates/egui_kittest/src/snapshot.rs
View File

@ -397,13 +397,24 @@ fn try_image_snapshot_options_impl(
Ok(())
};
let write_new_png = || {
new.save(&new_path)
.map_err(|err| SnapshotError::WriteSnapshot {
err,
path: new_path.clone(),
})?;
Ok(())
};
let previous = match image::open(&snapshot_path) {
Ok(image) => image.to_rgba8(),
Err(err) => {
// No previous snapshot - probablye a new test.
// No previous snapshot - probably a new test.
if mode.is_update() {
return update_snapshot();
} else {
write_new_png()?;
return Err(SnapshotError::OpenSnapshot {
path: snapshot_path.clone(),
err,
@ -416,6 +427,8 @@ fn try_image_snapshot_options_impl(
if mode.is_update() {
return update_snapshot();
} else {
write_new_png()?;
return Err(SnapshotError::SizeMismatch {
name,
expected: previous.dimensions(),
@ -454,11 +467,7 @@ fn try_image_snapshot_options_impl(
if below_threshold {
Ok(())
} else {
new.save(&new_path)
.map_err(|err| SnapshotError::WriteSnapshot {
err,
path: new_path.clone(),
})?;
write_new_png()?;
Err(SnapshotError::Diff {
name,