From 61e883be25c824ec82764150135f2e9ebf938f8b Mon Sep 17 00:00:00 2001 From: Sven Niederberger <73159570+s-nie@users.noreply.github.com> Date: Tue, 22 Apr 2025 11:52:20 +0200 Subject: [PATCH] Revert "Add `OutputCommand::SetPointerPosition` to set mouse position" (#5867) Reverts emilk/egui#5776 I noticed that this is already a `ViewportCommand`. Sorry for not seeing that earlier. --- crates/eframe/src/web/app_runner.rs | 3 --- crates/egui-winit/src/lib.rs | 3 --- crates/egui/src/context.rs | 5 ----- crates/egui/src/data/output.rs | 3 --- crates/egui_demo_lib/src/demo/tests/cursor_test.rs | 8 -------- 5 files changed, 22 deletions(-) diff --git a/crates/eframe/src/web/app_runner.rs b/crates/eframe/src/web/app_runner.rs index 835b7f00..76ae1761 100644 --- a/crates/eframe/src/web/app_runner.rs +++ b/crates/eframe/src/web/app_runner.rs @@ -336,9 +336,6 @@ impl AppRunner { egui::OutputCommand::OpenUrl(open_url) => { super::open_url(&open_url.url, open_url.new_tab); } - egui::OutputCommand::SetPointerPosition(_) => { - // Not supported on the web. - } } } diff --git a/crates/egui-winit/src/lib.rs b/crates/egui-winit/src/lib.rs index e541273f..fe4d2945 100644 --- a/crates/egui-winit/src/lib.rs +++ b/crates/egui-winit/src/lib.rs @@ -856,9 +856,6 @@ impl State { egui::OutputCommand::OpenUrl(open_url) => { open_url_in_browser(&open_url.url); } - egui::OutputCommand::SetPointerPosition(egui::Pos2 { x, y }) => { - let _ = window.set_cursor_position(winit::dpi::LogicalPosition { x, y }); - } } } diff --git a/crates/egui/src/context.rs b/crates/egui/src/context.rs index 44af99fe..6ec79f87 100644 --- a/crates/egui/src/context.rs +++ b/crates/egui/src/context.rs @@ -1494,11 +1494,6 @@ impl Context { self.send_cmd(crate::OutputCommand::CopyImage(image)); } - /// Set the mouse cursor position (if the platform supports it). - pub fn set_pointer_position(&self, position: Pos2) { - self.send_cmd(crate::OutputCommand::SetPointerPosition(position)); - } - /// Format the given shortcut in a human-readable way (e.g. `Ctrl+Shift+X`). /// /// Can be used to get the text for [`crate::Button::shortcut_text`]. diff --git a/crates/egui/src/data/output.rs b/crates/egui/src/data/output.rs index dcc03242..2fdaec1e 100644 --- a/crates/egui/src/data/output.rs +++ b/crates/egui/src/data/output.rs @@ -95,9 +95,6 @@ pub enum OutputCommand { /// Open this url in a browser. OpenUrl(OpenUrl), - - /// Set the mouse cursor position (if the platform supports it). - SetPointerPosition(emath::Pos2), } /// The non-rendering part of what egui emits each frame. diff --git a/crates/egui_demo_lib/src/demo/tests/cursor_test.rs b/crates/egui_demo_lib/src/demo/tests/cursor_test.rs index 6927e1af..78214d5e 100644 --- a/crates/egui_demo_lib/src/demo/tests/cursor_test.rs +++ b/crates/egui_demo_lib/src/demo/tests/cursor_test.rs @@ -16,14 +16,6 @@ impl crate::Demo for CursorTest { impl crate::View for CursorTest { fn ui(&mut self, ui: &mut egui::Ui) { - if ui - .button("Center pointer in window") - .on_hover_text("The platform may not support this.") - .clicked() - { - let position = ui.ctx().available_rect().center(); - ui.ctx().set_pointer_position(position); - } ui.vertical_centered_justified(|ui| { ui.heading("Hover to switch cursor icon:"); for &cursor_icon in &egui::CursorIcon::ALL {