skyler
/
egui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix input lag in drag-to-select o labels (#3917) 

Introduced in the recent drag-vs-click stuff
This commit is contained in:
Emil Ernerfeldt 2024-01-29 18:06:32 +01:00 committed by GitHub
parent 21253d844e
commit 6a94f4f5f0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
crates/egui/src/text_selection/label_text_selection.rs
View File

@ -372,16 +372,18 @@ impl LabelSelectionState {
selection.primary = selection.primary =
WidgetTextCursor::new(response.id, new_primary, galley_pos, galley); WidgetTextCursor::new(response.id, new_primary, galley_pos, galley);
if response.drag_started() { // We don't want the latency of `drag_started`.
let drag_started = ui.input(|i| i.pointer.any_pressed());
if drag_started {
if selection.layer_id == response.layer_id { if selection.layer_id == response.layer_id {
if ui.input(|i| i.modifiers.shift) { if ui.input(|i| i.modifiers.shift) {
// A continuation of a previous selection? // A continuation of a previous selection.
} else { } else {
// A new selection. // A new selection in the same layer.
selection.secondary = selection.primary; selection.secondary = selection.primary;
} }
} else { } else {
// A new selection. // A new selection in a new layer.
selection.layer_id = response.layer_id; selection.layer_id = response.layer_id;
selection.secondary = selection.primary; selection.secondary = selection.primary;
} }
@ -474,7 +476,7 @@ impl LabelSelectionState {
} }
self.any_hovered |= response.hovered(); self.any_hovered |= response.hovered();
self.is_dragging |= response.dragged(); self.is_dragging |= response.is_pointer_button_down_on(); // we don't want the initial latency of drag vs click decision
let old_selection = self.selection; let old_selection = self.selection;