Pass `ScreenDescriptor` to `egui_wgpu::CallbackTrait::prepare` (#3960)
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to add commits to your PR. * Remember to run `cargo fmt` and `cargo cranky`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> `glyphon` requires the screen resolution during the `prepare` stage, and passing that to the callback's `prepare` function seems pretty trivial. --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This commit is contained in:
parent
a5973e5cac
commit
7a6d80cc8c
|
|
@ -79,6 +79,7 @@ pub trait CallbackTrait: Send + Sync {
|
|||
&self,
|
||||
_device: &wgpu::Device,
|
||||
_queue: &wgpu::Queue,
|
||||
_screen_descriptor: &ScreenDescriptor,
|
||||
_egui_encoder: &mut wgpu::CommandEncoder,
|
||||
_callback_resources: &mut CallbackResources,
|
||||
) -> Vec<wgpu::CommandBuffer> {
|
||||
|
|
@ -890,6 +891,7 @@ impl Renderer {
|
|||
user_cmd_bufs.extend(callback.prepare(
|
||||
device,
|
||||
queue,
|
||||
screen_descriptor,
|
||||
encoder,
|
||||
&mut self.callback_resources,
|
||||
));
|
||||
|
|
|
|||
|
|
@ -2,7 +2,7 @@ use std::num::NonZeroU64;
|
|||
|
||||
use eframe::{
|
||||
egui_wgpu::wgpu::util::DeviceExt,
|
||||
egui_wgpu::{self, wgpu},
|
||||
egui_wgpu::{self, renderer::ScreenDescriptor, wgpu},
|
||||
};
|
||||
|
||||
pub struct Custom3d {
|
||||
|
|
@ -148,6 +148,7 @@ impl egui_wgpu::CallbackTrait for CustomTriangleCallback {
|
|||
&self,
|
||||
device: &wgpu::Device,
|
||||
queue: &wgpu::Queue,
|
||||
_screen_descriptor: &ScreenDescriptor,
|
||||
_egui_encoder: &mut wgpu::CommandEncoder,
|
||||
resources: &mut egui_wgpu::CallbackResources,
|
||||
) -> Vec<wgpu::CommandBuffer> {
|
||||
|
|
|
|||
Loading…
Reference in New Issue