From 7cee35c02a786d1e73eac035b29a34796f03d12c Mon Sep 17 00:00:00 2001 From: Valentin Date: Tue, 26 Nov 2024 15:23:43 +0100 Subject: [PATCH] document justification for FallbackEgl (#5392) The previous link does not explain why we chose FallbackEgl. This is a better link. --- crates/eframe/src/native/glow_integration.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/eframe/src/native/glow_integration.rs b/crates/eframe/src/native/glow_integration.rs index 476b1bdd..db721a64 100644 --- a/crates/eframe/src/native/glow_integration.rs +++ b/crates/eframe/src/native/glow_integration.rs @@ -941,7 +941,9 @@ impl GlutinWindowContext { // Create GL display. This may probably create a window too on most platforms. Definitely on `MS windows`. Never on Android. let display_builder = glutin_winit::DisplayBuilder::new() // we might want to expose this option to users in the future. maybe using an env var or using native_options. - .with_preference(glutin_winit::ApiPreference::FallbackEgl) // https://github.com/emilk/egui/issues/2520#issuecomment-1367841150 + // + // The justification for FallbackEgl over PreferEgl is at https://github.com/emilk/egui/pull/2526#issuecomment-1400229576 . + .with_preference(glutin_winit::ApiPreference::PreferEgl) .with_window_attributes(Some(egui_winit::create_winit_window_attributes( egui_ctx, event_loop,