skyler
/
egui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make text background rects pixel-sharp (#5864) 

Small visual teak: make sure the background text color is pixel-aligned.
This commit is contained in:
Emil Ernerfeldt 2025-03-30 16:21:00 +02:00 committed by GitHub
parent 995058bbd1
commit e3acd71090
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/egui_demo_lib/tests/snapshots/rendering_test/dpi_1.50.png
View File

@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:e6f394c2beb51d95edaf8c7ddc9ff62d3f95913ea88a3840245b6bacf8b850cc oid sha256:334f52bfee27f9c467de739696fd7ce7c48ec9013e315dc4b2e61eee58f11287
size 907997 size 907997

1
crates/egui_extras/src/syntax_highlighting.rs
View File

@ -33,6 +33,7 @@ pub fn highlight(
// performing it at a separate thread (ctx, ctx.style()) can be used and when ui is available // performing it at a separate thread (ctx, ctx.style()) can be used and when ui is available
// (ui.ctx(), ui.style()) can be used // (ui.ctx(), ui.style()) can be used
#[allow(non_local_definitions)]
impl egui::cache::ComputerMut<(&egui::FontId, &CodeTheme, &str, &str), LayoutJob> for Highlighter { impl egui::cache::ComputerMut<(&egui::FontId, &CodeTheme, &str, &str), LayoutJob> for Highlighter {
fn compute( fn compute(
&mut self, &mut self,

5
crates/epaint/src/text/text_layout.rs
View File

@ -715,7 +715,7 @@ fn tessellate_row(
mesh.reserve_vertices(row.glyphs.len() * 4); mesh.reserve_vertices(row.glyphs.len() * 4);
if format_summary.any_background { if format_summary.any_background {
add_row_backgrounds(job, row, &mut mesh); add_row_backgrounds(point_scale, job, row, &mut mesh);
} }
let glyph_index_start = mesh.indices.len(); let glyph_index_start = mesh.indices.len();
@ -753,7 +753,7 @@ fn tessellate_row(
/// Create background for glyphs that have them. /// Create background for glyphs that have them.
/// Creates as few rectangular regions as possible. /// Creates as few rectangular regions as possible.
fn add_row_backgrounds(job: &LayoutJob, row: &Row, mesh: &mut Mesh) { fn add_row_backgrounds(point_scale: PointScale, job: &LayoutJob, row: &Row, mesh: &mut Mesh) {
if row.glyphs.is_empty() { if row.glyphs.is_empty() {
return; return;
} }
@ -762,6 +762,7 @@ fn add_row_backgrounds(job: &LayoutJob, row: &Row, mesh: &mut Mesh) {
if let Some((color, start_rect, expand)) = start { if let Some((color, start_rect, expand)) = start {
let rect = Rect::from_min_max(start_rect.left_top(), pos2(stop_x, start_rect.bottom())); let rect = Rect::from_min_max(start_rect.left_top(), pos2(stop_x, start_rect.bottom()));
let rect = rect.expand(expand); let rect = rect.expand(expand);
let rect = rect.round_to_pixels(point_scale.pixels_per_point());
mesh.add_colored_rect(rect, color); mesh.add_colored_rect(rect, color);
} }
}; };