egui/crates
Lauro Oyen 5a6d1cbd58
Implement table row selection and hover highlighting (#3347)
* Based on #3105 by @vvv.

## Additions and Changes

- Add `TableBuilder::sense()` and `StripBuilder::sense()` to enable
detecting clicks or drags on table and strip cells.
- Add `TableRow::select()` which takes a boolean that sets the highlight
state for all cells added after a call to it. This allows highlighting
an entire row or specific cells.
- Add `TableRow::response()` which returns the union of the `Response`
of all cells added to the row up to that point. This makes it easy to
detect interactions with an entire row. See below for an alternative
design.
- Add `TableRow::index()` and `TableRow::col_index()` helpers.
- Remove explicit `row_index` from callback passed to
`TableBody::rows()` and `TableBody::heterogeneous_rows()`, possible due
to the above. This is a breaking change but makes the callback
compatible with `TableBody::row()`.
- Update Table example to demonstrate all of the above.

## Design Decisions

An alternative design to `TableRow::response()` would be to return the
row response from `TableBody`s `row()`, `rows()` and
`heterogeneous_rows()` functions. `row()` could just return the
response. `rows()` and `heterogeneous_rows()` could return a tuple of
the hovered row index and that rows response. I feel like this might be
the cleaner soluction if only returning the hovered rows response isn't
too limiting.

I didn't implement `TableBuilder::select_rows()` as described
[here](https://github.com/emilk/egui/pull/3105#issuecomment-1618062533)
because it requires an immutable borrow of the selection state for the
lifetime of the `TableBuilder`. This makes updating the selection state
from within the body unnecessarily complicated. Additionally the current
design allows for selecting specific cells, though that could be
possible by modifying `TableBuilder::select_rows()` to provide row and
column indices like below.

```rust
pub fn select_cells(is_selected: impl Fn(usize, usize) -> bool) -> Self
```

## Hover Highlighting

EDIT: Thanks to @samitbasu we now have hover highlighting too.

~This is not implemented yet. Ideally we'd have an api that allows to
choose between highlighting the hovered cell, column or row. Should
cells containing interactive widgets, be highlighted when hovering over
the widget or only when hovering over the cell itself? I'd like to
implement that before this gets merged though.~

Feedback is more than welcome. I'd be happy to make any changes
necessary to get this merged.

* Closes #1519
* Closes #1553
* Closes #3069

---------

Co-authored-by: Samit Basu <basu.samit@gmail.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
2024-01-06 18:10:34 +01:00
..
ecolor Fix some clippy 1.75 lints (#3754) 2023-12-30 11:23:21 +01:00
eframe `eframe`: Fix building the `wasm32` docs for `docs.rs` (#3757) 2023-12-31 10:26:02 +01:00
egui Allow arrow keys to move away focus from a Slider (#3641) 2024-01-06 17:39:34 +01:00
egui-wgpu Bump `winit` to `0.29.7` (#3753) 2024-01-02 07:27:52 +01:00
egui-winit Ignore extra SHIFT and ALT when matching modifiers (#3769) 2024-01-05 10:53:14 +01:00
egui_demo_app Fix some clippy 1.75 lints (#3754) 2023-12-30 11:23:21 +01:00
egui_demo_lib Implement table row selection and hover highlighting (#3347) 2024-01-06 18:10:34 +01:00
egui_extras Implement table row selection and hover highlighting (#3347) 2024-01-06 18:10:34 +01:00
egui_glow Update to glow 0.13 (#3715) 2023-12-18 15:15:20 +01:00
egui_plot Release `egui_plot` 0.24.2 (#3763) 2024-01-03 09:42:56 +01:00
egui_web Fix typos (#2866) 2023-04-18 15:52:45 +02:00
emath Add a bunch of `#[inline]` 2023-12-18 17:28:47 +01:00
epaint Fix text color of disabled widgets (#3744) 2023-12-28 11:16:39 +01:00