Avoid interacting twice when not required (#4041)

This PR short-circuits `Response::interact()` when the `Response` has
already been sufficiently "sensed" already. In some circumstance, this
can avoid unnecessarily registering another widget rect that may mask
some other widget.

One such instance is Rerun's `ListItem`. Calling `context_menu()` on its
response would call `interact` and, in turn, mask its sub-widget
(collapsing triangle, show/hide buttons, etc.).
This commit is contained in:
Antoine Beyeler 2024-02-14 09:07:33 +01:00 committed by GitHub
parent d99fabaef5
commit 0e1bcc2c1c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 0 deletions

View File

@ -610,6 +610,13 @@ impl Response {
/// ```
#[must_use]
pub fn interact(&self, sense: Sense) -> Self {
// Test if we must sense something new compared to what we have already sensed. If not, then
// we can return early. This may avoid unnecessarily "masking" some widgets with unneeded
// interactions.
if (self.sense | sense) == self.sense {
return self.clone();
}
self.ctx.interact_with_hovered(
self.layer_id,
self.id,