Exclude icon.png from lfs (#5336)

* Closes #5331 
* [x] I have followed the instructions in the PR template

.gitattributes

@@ -1,3 +1,5 @@
 * text=auto eol=lf
 Cargo.lock linguist-generated=false
 *.png filter=lfs diff=lfs merge=lfs -text
+# The icon.png is needed when including eframe via git, so it may not be in lfs
+crates/eframe/data/* !filter !diff !merge text=auto eol=lf

.github/workflows/png_only_on_lfs.yml

@@ -13,10 +13,11 @@ jobs:
     - name: Check that png files are on git LFS
       run: |
         binary_extensions="png"
+        exclude="crates/eframe/data"
 
         # Find binary files that are not tracked by Git LFS
         for ext in $binary_extensions; do
-          if comm -23 <(git ls-files | sort) <(git lfs ls-files -n | sort) | grep "\.${ext}$"; then
+          if comm -23 <(git ls-files | grep -v "^$exclude" | sort) <(git lfs ls-files -n | sort) | grep "\.${ext}$"; then
             echo "Error: Found binary file with extension .$ext not tracked by git LFS. See CONTRIBUTING.md"
             exit 1
           fi